chore: initialize #3

kingsley-einstein · 2024-09-26T01:24:29Z

Resolves #1

.eslintrc

github-actions · 2024-09-26T05:30:09Z

Unused files (1)

src/scripts/custom-chains.ts

ubiquity-os-deployer · 2024-09-26T05:30:40Z

f6708d9

6726d0f

cb8adb1

0addf0f

6995d6e

fbdf50a

4e0aeb5

8bdc118

1deeb47

809ec2e

6fe4bf0

f07a96b

0x4007 · 2024-10-02T13:02:26Z

src/scripts/constants.ts

@@ -0,0 +1,299 @@
+export const ufaucetAbi = [


I would just make this a JSON file its cleaner that way.

I want to take advantage of typing this way.

src/scripts/connect-wallet.ts

package.json

src/scripts/mint.ts

src/scripts/redeem.ts

kingsley-einstein · 2024-10-28T05:57:58Z

@0x4007 I just realized that I was previously unassigned from this task. I already raised a PR.

ubiquity-os · 2024-11-08T10:16:15Z

@zugdev, this task has been idle for a while. Please provide an update.

kingsley-einstein · 2024-11-08T21:59:43Z

@rndquu

The listed criteria in #1 (comment) have been satisfied by the latest push.

ubiquity-os · 2024-11-10T11:27:40Z

@kingsley-einstein, this task has been idle for a while. Please provide an update.

rndquu

@kingsley-einstein

Pls merge feat: add UBQ fund test script kingsley-einstein/uusd.ubq.fi#3
Check this screenshot:

Somehow when I enter 100 UUSD to mint the actually passed amount is 100000000 while the expected amount is 100000000000000000000. There's smth wrong with decimals. Pls check all over the code.

feat: add UBQ fund test script

kingsley-einstein · 2024-11-11T16:16:41Z

@kingsley-einstein

Pls merge feat: add UBQ fund test script kingsley-einstein/uusd.ubq.fi#3

Check this screenshot:

Somehow when I enter 100 UUSD to mint the actually passed amount is 100000000 while the expected amount is 100000000000000000000. There's smth wrong with decimals. Pls check all over the code.

@rndquu
I'm on it now.

kingsley-einstein · 2024-11-11T16:39:19Z

@rndquu
Changes have been made. It turns out I had hardcoded the decimals.

zugdev · 2024-11-11T21:05:23Z

User should be able to mint without specifying slippage, in that case you should pass in 0 for min and maxInt for max.

zugdev · 2024-11-11T21:08:00Z

By the screenshot it looks like mint with governance value is either always true or inverted.

zugdev · 2024-11-11T21:10:09Z

When I fill the form initially the mint button is visible. Only after the allowance check runs it displays the approval button. The button should be disabled until allowance is checked, because if user proceeds to quickly press the mint button he will get reverted.

Screen.Recording.2024-11-11.180859.mp4

zugdev · 2024-11-11T21:14:47Z

Also, displaying the minting/redeeming fees is important. In the LUSD case, currently it's 0%, but you should read it dynamically from the collateralInfo function. It's vital as the fees are a part of our planned business model and will be non-null in near future. You can refer to the code I wrote for this: https://github.com/zugdev/uusd.ubq.fi/blob/f4c6623cec130cff75e299ca47f0a45b63ace819/src/pages/mint.ts#L48-L85

zugdev · 2024-11-11T21:45:40Z

The button seems to be generally a little inconsistent, it flickers:

Screen.Recording.2024-11-11.182203.mp4

I suggest on form update you check allowances to determine the button's state.

zugdev

@rndquu, I've left a few comments and suggestions. @kingsley-einstein, please wait for him to check them before you implement those, he might disagree with some.

zugdev · 2024-11-11T21:28:23Z

src/scripts/faucet.ts

+
+const CLIENT_OR_ACCOUNT_ERROR = "Client or account not initialized";
+
+export async function getAllCollaterals() {


You are creating a contract instance and a public function for every single contract method, there is no need to do that. As in viem docs, you should make a public contract instance and then you can directly call it's methods. From their official documentation:

import { getContract } from 'viem' import { wagmiAbi } from './abi' import { publicClient, walletClient } from './client' // 1. Create contract instance const contract = getContract({ address: '0xFBA3912Ca04dd458c843e2EE08967fC04f3579c2', abi: wagmiAbi, // 1a. Insert a single client client: publicClient, // 1b. Or public and/or wallet clients client: { public: publicClient, wallet: walletClient } }) // 2. Call contract methods, fetch events, listen to events, etc. const result = await contract.read.totalSupply() const logs = await contract.getEvents.Transfer() const unwatch = contract.watchEvent.Transfer( { from: '0xA0Cf798816D4b9b9866b5330EEa46a18382f251e' }, { onLogs(logs) { console.log(logs) } } )

zugdev · 2024-11-11T21:31:56Z

src/scripts/mint.ts

+let maxGovernanceIn = 0;
+let isOneToOne = false;
+
+let isButtonInteractionsDisabled = false;


I don't think there is a need to have this variable as you can just use mintButton.disabled to check the status. This could be the cause for the button's inconsistency.

zugdev · 2024-11-11T21:32:09Z

src/scripts/mint.ts

+let dollarOutMin = 0;
+let maxCollateralIn = 0;
+let maxGovernanceIn = 0;
+let isOneToOne = false;


This should initially be true.

zugdev · 2024-11-11T21:32:48Z

src/scripts/mint.ts

+
+const collateralRecord: Record<string | number, `0x${string}`> = {};
+const toastActions = new ToastActions();
+const publicClient = createPublicClient({


You are creating multiple clients. Why not share a single client with the entire app?

zugdev · 2024-11-11T21:34:24Z

src/scripts/mint.ts

+          const web3Client = getConnectedClient();
+
+          if (allowanceButton !== null)
+            allowanceButton.disabled = web3Client === null || !collateralAddress || !web3Client.account || isButtonInteractionsDisabled;


It would be prettier if you consolidated allowanceButton and mintButton into an actionButton, since they are never displayed concomitantly and share the same objective.

zugdev · 2024-11-11T21:44:43Z

src/scripts/redeem.ts

@@ -0,0 +1,259 @@
+import { createPublicClient, http, parseUnits, BaseError } from "viem";


The comments in mint.ts should make sense here too.

zugdev · 2024-11-11T21:46:45Z

src/main.ts

+  wallet.updateConnectButtonText("");
+
+  await wallet.connectIfAuthorized();
+  await mint.initCollateralList();


The collateral list is shared between mint and redeem. Making it global is a good idea.

zugdev · 2024-11-11T21:47:20Z

cypress.config.ts

@@ -6,6 +6,6 @@ export default defineConfig({
      // implement node event listeners here
    },
    experimentalStudio: true,
-    baseUrl: "http://localhost:8080",
+    baseUrl: "http://localhost:10090",


8080 is the default HTML port, why change it?

zugdev · 2024-11-11T21:49:43Z

src/scripts/utils.ts

+}
+
+//eslint-disable-next-line @typescript-eslint/no-explicit-any
+export function toSf(i: any, sf: number = 3) {


This naming isn't clear

zugdev · 2024-11-11T21:52:54Z

static/mint.html

+    <link rel="stylesheet" href="style/style.css" />
+  </head>
+  <body class="w-screen overflow-x-hidden min-h-screen drawer">
+    <main class="container mx-auto flex max-w-full lg:w-[80%] flex-col justify-start items-center py-4 px-4 lg:px-5 gap-12 overflow-x-hidden drawer-content">


Styling in class name / Tailwind is not used within our UIs, tho I am not sure if it matters as styling will be made in a future PR

rndquu

Overall looks good.

@zugdev I've added some of your notes to a separate issue. Feel free to update it if there're any UI bugs. Regarding the comments on the code, I think they can be addressed in a separate PR.

ubiquity-os · 2024-11-16T17:23:31Z

@kingsley-einstein, this task has been idle for a while. Please provide an update.

kingsley-einstein · 2024-11-16T17:26:05Z

@kingsley-einstein, this task has been idle for a while. Please provide an update.

Still under review

chore: initialize

f6708d9

0x4007 requested changes Sep 26, 2024

View reviewed changes

.eslintrc Outdated Show resolved Hide resolved

kingsley-einstein added 4 commits September 26, 2024 10:07

chore: made updates

f64e5c3

chore: made updates

a648dea

feat: add providers list modal

6726d0f

feat: create functions to interact with blockchain

f8f571e

0x4007 reviewed Oct 2, 2024

View reviewed changes

src/scripts/connect-wallet.ts Outdated Show resolved Hide resolved

0x4007 reviewed Oct 2, 2024

View reviewed changes

src/scripts/connect-wallet.ts Outdated Show resolved Hide resolved

kingsley-einstein added 8 commits October 2, 2024 22:19

chore: make requested changes

001d880

chore: made requested changes

95d2015

feat: begin working on minting page

5a9ea09

chore: small update to let the guys know I'm still on this

2182135

chore: update ui

e320389

chore: add tailwindcss for convenience

cb8adb1

chore: update minting page

0addf0f

chore: update mint.ts

7e705c1

whilefoo reviewed Oct 23, 2024

View reviewed changes

package.json Show resolved Hide resolved

kingsley-einstein added 4 commits October 23, 2024 12:39

chore: made updates

6a0e398

chore: finish minting page

67f5d1a

chore: finish

5be5157

chore: finish

393f476

kingsley-einstein marked this pull request as ready for review October 26, 2024 05:19

0x4007 reviewed Oct 26, 2024

View reviewed changes

src/scripts/mint.ts Outdated Show resolved Hide resolved

0x4007 reviewed Oct 26, 2024

View reviewed changes

src/scripts/redeem.ts Outdated Show resolved Hide resolved

chore: made requested changes

e0a6a68

0x4007 requested a review from rndquu October 27, 2024 12:57

kingsley-einstein mentioned this pull request Nov 4, 2024

Create UI for UbiquityPool #1

Open

rndquu self-requested a review November 8, 2024 15:13

chore: made fixes

1deeb47

fix: knip issues

809ec2e

0x4007 mentioned this pull request Nov 10, 2024

Wrong pull follow up ubiquity-os-marketplace/daemon-disqualifier#46

Open

rndquu requested review from rndquu and removed request for rndquu November 11, 2024 15:31

feat: add UBQ fund test script

283223e

rndquu requested changes Nov 11, 2024

View reviewed changes

rndquu marked this pull request as draft November 11, 2024 16:12

Merge pull request #3 from rndquu/chore/add-ubq-fund-helper

6fe4bf0

feat: add UBQ fund test script

chore: remove hardcoded decimals

f07a96b

kingsley-einstein marked this pull request as ready for review November 11, 2024 16:35

zugdev reviewed Nov 11, 2024

View reviewed changes

rndquu self-requested a review November 14, 2024 14:49

rndquu mentioned this pull request Nov 14, 2024

Small UI improvements for uusd.ubq.fi #14

Open

rndquu approved these changes Nov 14, 2024

View reviewed changes

kingsley-einstein requested a review from 0x4007 November 14, 2024 17:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: initialize #3

chore: initialize #3

kingsley-einstein commented Sep 26, 2024

github-actions bot commented Sep 26, 2024 •

edited

Loading

ubiquity-os-deployer bot commented Sep 26, 2024 •

edited

Loading

0x4007 Oct 2, 2024

kingsley-einstein Oct 2, 2024

kingsley-einstein commented Oct 28, 2024

ubiquity-os bot commented Nov 8, 2024

kingsley-einstein commented Nov 8, 2024

ubiquity-os bot commented Nov 10, 2024

rndquu left a comment

kingsley-einstein commented Nov 11, 2024

kingsley-einstein commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev left a comment

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

zugdev Nov 11, 2024

rndquu left a comment

ubiquity-os bot commented Nov 16, 2024

kingsley-einstein commented Nov 16, 2024


		const CLIENT_OR_ACCOUNT_ERROR = "Client or account not initialized";

		export async function getAllCollaterals() {

		@@ -0,0 +1,259 @@
		import { createPublicClient, http, parseUnits, BaseError } from "viem";

chore: initialize #3

Are you sure you want to change the base?

chore: initialize #3

Conversation

kingsley-einstein commented Sep 26, 2024

github-actions bot commented Sep 26, 2024 • edited Loading

Unused files (1)

ubiquity-os-deployer bot commented Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kingsley-einstein commented Oct 28, 2024

ubiquity-os bot commented Nov 8, 2024

kingsley-einstein commented Nov 8, 2024

ubiquity-os bot commented Nov 10, 2024

rndquu left a comment

Choose a reason for hiding this comment

kingsley-einstein commented Nov 11, 2024

kingsley-einstein commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev commented Nov 11, 2024

zugdev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rndquu left a comment

Choose a reason for hiding this comment

ubiquity-os bot commented Nov 16, 2024

kingsley-einstein commented Nov 16, 2024

github-actions bot commented Sep 26, 2024 •

edited

Loading

ubiquity-os-deployer bot commented Sep 26, 2024 •

edited

Loading