-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch for c++20 modules raw support #253
base: main
Are you sure you want to change the base?
Conversation
This is work of @Cheaterdev, details are in: ubisoft#145 ubisoft#146
This one-liner (by @Cheaterdev) allows to work with c++20 modules flawlessly, could you please do some regression tests on this? |
belkiss is no longer working at ubisoft, sadly. I will take a look at this in the next few days. |
@jspelletier: ack, I appreciate it... waiting for yours analysis |
this modifies a bunch of vcxproj and adds a lots of unwanted project reference to our vcxproj. Why don't you instead set ExportAdditionalLibrariesEvenForStaticLib to true in your configurations? Would be equivalent to the if condition that you removed(I think). Or if this is not possible and doesn't work, would need to hide this new behavior behind some feature flag(possibly a new bool in Project.Configuration) |
I will conduct some tests based on your recommendation, give me a few hours. |
Because when having multiple projects with modules it starts exporting lib files as well and linker is going crazy - a lot of duplicates. We just need proper references between projects, nothing more. |
This is work of @Cheaterdev, details are in:
#145
#146