Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for c++20 modules raw support #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChemistAion
Copy link

This is work of @Cheaterdev, details are in:
#145
#146

@ChemistAion
Copy link
Author

ChemistAion commented Mar 10, 2023

This one-liner (by @Cheaterdev) allows to work with c++20 modules flawlessly, could you please do some regression tests on this?
...since @belkiss (involved in these discussions) stopped responding :|

@jspelletier
Copy link
Collaborator

belkiss is no longer working at ubisoft, sadly. I will take a look at this in the next few days.

@jspelletier jspelletier self-assigned this Mar 21, 2023
@ChemistAion
Copy link
Author

@jspelletier: ack, I appreciate it... waiting for yours analysis

@jspelletier
Copy link
Collaborator

jspelletier commented Mar 21, 2023

this modifies a bunch of vcxproj and adds a lots of unwanted project reference to our vcxproj.

Why don't you instead set ExportAdditionalLibrariesEvenForStaticLib to true in your configurations? Would be equivalent to the if condition that you removed(I think). Or if this is not possible and doesn't work, would need to hide this new behavior behind some feature flag(possibly a new bool in Project.Configuration)

@ChemistAion
Copy link
Author

I will conduct some tests based on your recommendation, give me a few hours.

@Cheaterdev
Copy link

this modifies a bunch of vcxproj and adds a lots of unwanted project reference to our vcxproj.

Why don't you instead set ExportAdditionalLibrariesEvenForStaticLib to true in your configurations? Would be equivalent to the if condition that you removed(I think). Or if this is not possible and doesn't work, would need to hide this new behavior behind some feature flag(possibly a new bool in Project.Configuration)

Because when having multiple projects with modules it starts exporting lib files as well and linker is going crazy - a lot of duplicates. We just need proper references between projects, nothing more.

@jspelletier jspelletier changed the base branch from dev to main April 6, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants