Sharpmake.Options.Vc.Compiler.UseStandardConformingPreprocessor support #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmingPreprocessor" to set the additional option "/Zc:preprocessor" https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor?view=msvc-170
|
This seems reasonable. We’ll discuss it next week. |
jspelletier
reviewed
Oct 11, 2024
jspelletier
reviewed
Oct 11, 2024
| context.SelectOption | ||
| ( | ||
| Options.Option(Options.Vc.Compiler.UseStandardConformingPreprocessor.Default, () => { }), | ||
| Options.Option(Options.Vc.Compiler.UseStandardConformingPreprocessor.Disable, () => { context.Configuration.AdditionalCompilerOptions.Add("/Zc:preprocessor-"); }), |
There was a problem hiding this comment.
this is wrong. Could can't modify Configuration here.
There was a problem hiding this comment.
The implementation should be similar to other options. See
Options.Vc.Compiler.GenerateProcessorFile.Disable just above this code which is a very similar option.
There was a problem hiding this comment.
I added similar setup to Options.Vc.Compiler.GenerateProcessorFile.
…rmingPreprocessor", which: * adds the additional command line argument "/Zc:preprocessor[-]" * sets the "UseStandardPreprocessor" option in vcxproj
jspelletier
pushed a commit
that referenced
this pull request
Oct 31, 2024
…rt (#387) * Added compiler option "Sharpmake.Options.Vc.Compiler.UseStandardConformingPreprocessor" to set the additional option "/Zc:preprocessor" https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor?view=msvc-170 * Added compiler option "Sharpmake.Options.Vc.Compiler.UseStandardConformingPreprocessor", which: * adds the additional command line argument "/Zc:preprocessor[-]" * sets the "UseStandardPreprocessor" option in vcxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compiler option "Sharpmake.Options.Vc.Compiler.UseStandardConformingPreprocessor" to set the additional option "/Zc:preprocessor"
https://learn.microsoft.com/en-us/cpp/build/reference/zc-preprocessor?view=msvc-170