Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(decky): change Decky's default 45 sec timeout to 5 seconds #1531

Closed
wants to merge 1 commit into from

Conversation

aarron-lee
Copy link
Contributor

Decky, by default, has a 45 second timeout in it's systemd service. Decky doesn't seem to capture any signals such as SIGINT from the OS, and thus, is not shutting down gracefully.

This leads to perceived slowness when shutting down a device with Decky installed.

As a workaround, this PR changes the 45 second timeout with the setup-decky ujust

Decky issue for 45s timeout: SteamDeckHomebrew/decky-loader#683

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. steam-deck For Steam Deck issues labels Aug 22, 2024
@KyleGospo
Copy link
Member

KyleGospo commented Aug 22, 2024

Instead of a sed in the installer I think this can be done as a pre included override file so it applies to existing installs and exists in a file decky doesn't control.

Great change by the way, thanks.

@KyleGospo
Copy link
Member

KyleGospo commented Aug 22, 2024

Should be something like:
/etc/systemd/system/plugin_loader.service.d/override.conf

[Service]
TimeoutStopSec=5

@KyleGospo KyleGospo changed the base branch from main to testing August 22, 2024 18:48
@aarron-lee
Copy link
Contributor Author

Should be something like: /etc/systemd/system/plugin_loader.service.d/override.conf

[Service]
TimeoutStopSec=5

makes sense, I'll close this PR for now and investigate opening another one later with the recommended override.

@aarron-lee aarron-lee closed this Aug 22, 2024
@aarron-lee aarron-lee deleted the fix_decky_timeout branch August 22, 2024 18:53
@KyleGospo
Copy link
Member

@aarron-lee Merged the fix I suggested w/ you tagged, thanks!

@aarron-lee
Copy link
Contributor Author

@KyleGospo saw that, thanks for adding the fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files. steam-deck For Steam Deck issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants