fix: min_battery_percent = 0 now works to "skip" battery check #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyemxela
force-pushed
the
min_batt_zero_skip
branch
from
eaf16da
to
5ad9228
Compare
reyemxela
changed the title
|
LGTM |
gerblesh
approved these changes
Oct 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until giampaolo/psutil#2305 is merged, machines with no battery can fail the check if they have external devices that are reporting battery levels (#79).
In my case, my wireless Logitech headphones report 0% battery if the dongle is plugged in but the headphones are off, and even setting
min_battery_percent = 0in the config doesn't work, because 0 is not greater than 0.This little tweak just makes it so 0 values pass the check correctly.
Could make a special case for
min_battery_percent = 0to skip the check entirely instead, not sure which would be more preferred.