Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Installing section for manage page #1810

Merged
merged 13 commits into from
Sep 11, 2024
Merged

feat: Installing section for manage page #1810

merged 13 commits into from
Sep 11, 2024

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Sep 5, 2024

Screencast.from.2024-09-10.18-17-37.webm

This also contains some small fixes for buttons and spacing + consolidates the code for the "button bars".

@anasereijo
Copy link
Collaborator

whoop whooppp 🙌

the only thing missing is the cancel button:

Screenshot 2024-09-06 at 09 54 32

Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, I noticed that there's also some space missing between the 'Install' and 'Cancel' buttons on the app page.

On this PR: looks great and works well! Feel free to merge it after adding the cancel button Ana requested :)

@anasereijo
Copy link
Collaborator

Unrelated to this PR, I noticed that there's also some space missing between the 'Install' and 'Cancel' buttons on the app page.

@d-loose great catch! you can officially become a designer now ;) haha

@spydon
Copy link
Collaborator Author

spydon commented Sep 6, 2024

whoop whooppp 🙌

the only thing missing is the cancel button:

@anasereijo Ah right, should the update list also have a cancel button? It doesn't in Figma, and maybe it's unnecessary, like who cancels and update that they've started... Just checking if the button bars should be the same across the lists.

Screencast.from.2024-09-06.11-31-12.webm

@spydon spydon requested a review from d-loose September 10, 2024 17:22
@anasereijo
Copy link
Collaborator

Looks goooood 🥇

@spydon spydon merged commit ec5d43d into main Sep 11, 2024
8 checks passed
@spydon spydon deleted the feat/installing-section branch September 11, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants