Rework build-setup | Add single-node CI #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
reviewed
Dec 8, 2022
jerryz123
reviewed
Dec 8, 2022
jerryz123
reviewed
Dec 8, 2022
jerryz123
reviewed
Dec 8, 2022
abejgonzalez
force-pushed
the
full-setup
branch
from
968ae89
to
a37a935
Compare
abejgonzalez
force-pushed
the
full-setup
branch
from
97e8605
to
5996ec6
Compare
|
@jerryz123 Re-review request! |
jerryz123
reviewed
Dec 12, 2022
scripts/build-setup.sh
Outdated
| * ) | ||
| error "invalid option $1" | ||
| usage 1 ;; | ||
| esac | ||
| shift | ||
| done | ||
|
|
||
| if [ "$SKIP_CONDA" = false ]; then | ||
| # check if the arg is found in the SKIP_LIST | ||
| do_skip() { |
There was a problem hiding this comment.
This is a bit confusing, since if do_skip evaluates to true, the block is run.
Perhaps rename do_skip to run_step, where run_step returns true if the ARG is not in the SKIP_LIST.
jerryz123
reviewed
Dec 12, 2022
scripts/build-setup.sh
Outdated
| popd | ||
| fi | ||
|
|
||
| if do_skip "6"; then |
There was a problem hiding this comment.
Nit: Add comment before each block specifying what the block does
jerryz123
requested changes
Dec 12, 2022
Remove conda from build-toolchains-extra.sh
jerryz123
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
build-setup.shscript to initialize as much as possible (FireSim, FireMarshal, tags, etc). However, there is a new opt-out mechanism for power-users to disable different parts of the setup (this is not tested extensively). Additionally, this PR adds a new CI workflow where a persistent CI clone is set up and regressed on (in the future this will be used to regress on the tutorial setup).Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?