Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed FireSim tests and harnesses #1317

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Removed FireSim tests and harnesses #1317

merged 1 commit into from
Jan 31, 2023

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Jan 31, 2023

These tests were moved to FireSim itself. This PR removes them from Chipyard.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • x ] Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

These tests were moved to FireSim itself. This PR removes them from Chipyard.
@jerryz123
Copy link
Contributor

Can you see my comment in the fsim PR where I raised this issue? I'd like to keep these tests if possible.

@jerryz123
Copy link
Contributor

Ok I see how the tests are mirrored in firesim now, if this passes the CI I'll merge this.

@nandor
Copy link
Contributor Author

nandor commented Jan 31, 2023

Thanks!

@jerryz123 jerryz123 self-requested a review January 31, 2023 17:46
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jerryz123 jerryz123 merged commit 6fbdacb into main Jan 31, 2023
@jerryz123 jerryz123 deleted the remove-tests branch January 31, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants