Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verilator Install Location | Re-add HTIF arg parsing | Pass Errors Correctly in *.out #134

Merged
merged 5 commits into from
Jul 8, 2019

Conversation

abejgonzalez
Copy link
Contributor

Added support to change the Verilator install location. Should help with CI efforts.

@abejgonzalez abejgonzalez self-assigned this Jul 6, 2019
@abejgonzalez abejgonzalez changed the title Different Verilator install location Verilator Install Location | Re-add HTIF arg parsing | Pass Errors Correctly in *.out Jul 8, 2019
@abejgonzalez abejgonzalez requested a review from zhemao July 8, 2019 21:36
@abejgonzalez
Copy link
Contributor Author

Updated the PR to include fixing the CI so that Verilator runs correctly and so that tests properly error out (instead of being masked by spike-dasm). Need to check the CI passes AND that there is reasonable output.

@abejgonzalez
Copy link
Contributor Author

#129 Is the PR being reverted here until Verilator can support +permissive/+permissive-off

Copy link
Contributor

@zhemao zhemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez merged commit 2948ba8 into dev Jul 8, 2019
jerryz123 added a commit that referenced this pull request Apr 19, 2023
Summary: adding <stdexcept> to testchip_tsi.cc
jerryz123 pushed a commit that referenced this pull request Apr 19, 2024
Dump per macro verilog (overridden by final verilog output)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants