Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support banked/partitioned scratchpads #1431

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Support banked/partitioned scratchpads #1431

merged 2 commits into from
Jun 13, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Apr 8, 2023

This generalized the backing-scratchpad feature in testchipip to support -

  • Placing the spad at arbitrary buses
  • Banking the scratchpad by cacheline
  • Placing multiple scratchpads on the bus, this allows for construction of scratchpad "partitions"

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 marked this pull request as ready for review June 9, 2023 07:07
@jerryz123 jerryz123 requested a review from SeahK June 13, 2023 08:11
Copy link
Contributor

@SeahK SeahK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and worked well on spike/vcs/firesim

@jerryz123 jerryz123 merged commit fa6d772 into main Jun 13, 2023
@jerryz123 jerryz123 deleted the bankedspad branch June 13, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants