Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always initialize fpga-shells with init-submodules.sh #1456

Merged
merged 2 commits into from
May 8, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented May 3, 2023

FPGA shells is ultra fast to clone, ans we are moving towards init-all approach anyways

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also remove the associated init-fpga script and update the docs.

FPGA shells is ultra fast to clone, and this makes the normal repo init script actually set up the repo properly for all possible use cases.
@jerryz123 jerryz123 merged commit 9209a72 into main May 8, 2023
@jerryz123 jerryz123 deleted the jerryz123-patch-2 branch May 8, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants