Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note automation #1548

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Add release note automation #1548

merged 3 commits into from
Jul 10, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Jul 5, 2023

Follows the same type of automation done by chipsalliance/chisel#3170. Note: This doesn't append to the CHANGELOG.md file.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know what this is doing from this PR, but it seems fine at a glance.

@jerryz123
Copy link
Contributor

Perhaps wait until post-release to merge this?

@abejgonzalez
Copy link
Contributor Author

abejgonzalez commented Jul 5, 2023

I'm interested to see if it works for this release (do we not have a changelog made already)? - Edit: I see you already did it.

@abejgonzalez abejgonzalez merged commit 687e791 into main Jul 10, 2023
@abejgonzalez abejgonzalez deleted the release-automation branch July 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants