Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: SiFive peripheral device doumentation #1578

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Improve: SiFive peripheral device doumentation #1578

merged 3 commits into from
Aug 21, 2023

Conversation

T-K-233
Copy link
Member

@T-K-233 T-K-233 commented Aug 21, 2023

Add documentation on sifive peripheral devices and example code of how to add them to the ChipConfig.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@T-K-233 T-K-233 marked this pull request as ready for review August 21, 2023 22:27
jerryz123
jerryz123 requested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, otherwise looks good!

@jerryz123
Copy link
Contributor

Thanks!

@jerryz123 jerryz123 merged commit a4382e6 into main Aug 21, 2023
53 of 56 checks passed
@T-K-233 T-K-233 deleted the periphery-docs branch August 22, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryz123 jerryz123 jerryz123 approved these changes

@abejgonzalez abejgonzalez Awaiting requested review from abejgonzalez

Assignees
No one assigned
Labels
changelog:added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T-K-233 @jerryz123