Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added useful "Build script exited at step X" errors for each step in build-setup.sh #1614

Merged
merged 7 commits into from
Oct 9, 2023

Commits on Oct 5, 2023

  1. Added "try-catch" to all build-setup steps

    This was the only way I knew how to display the step at which the build-setup process failed.
    I've personally experienced failures at multiple of the build steps, and before I got used to Chipyard,
    it was hard to figure out which step was the culprit. With this, users should have a bit more info to
    troubleshoot their issues. For some of the build steps that required multiple lines, I figured it made
    more sense to put them into a sub-script, rather than putting a && at the end of each line. But for the
    firesim one for example, since it was two .sh calls, I just put a && after the first one, inside of the
    try block, to make sure both lines run.
    JL102 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    6b70dd6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b7057c View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Replaced "try-catch" with a more special-purpose set of functions

    This also fixed the weird issue I was experiencing where the try-catch in step 1 caused step 3 to break
    JL102 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b76ab6b View commit details
    Browse the repository at this point in the history
  2. Made indentation consistent

    JL102 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    aded25f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a7993db View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9b55722 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. Configuration menu
    Copy the full SHA
    5bbebb8 View commit details
    Browse the repository at this point in the history