-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild jar
s when sv
/v
files are changed + Add documentation on blackboxes
#1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
reviewed
Nov 1, 2023
jerryz123
reviewed
Nov 1, 2023
Testing with |
12 tasks
abejgonzalez
changed the title
Bb fixes
Rebuild Nov 2, 2023
jar
s when sv
/v
files are changed + Add documentation on blackboxes
16 tasks
jerryz123
reviewed
Nov 3, 2023
jerryz123
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jar
generation so that Verilog files are properly updated in thejar
. This was bugged before since you would have to recompile Scala sources to see the Verilog sources change.include
hasinclude
within it, rerun the replacement)generate-conda-lockfiles
script to delete the lockfile before regenerating (fixes issue whereconda-lock
would get stuck regenerating the lockfile if the lockfile pre-existed)It also exposes a bug mentioned here: #1624 (comment). This is an issue in MFC that needs to get solved.
The error being that duplicate
addPath
calls cannot exist (not sure if having a different module name will fix the issue). Error message is the following:Cannot find file /scratch/abejgonza/cy/generators/chipyard/src/main/resources/vsrc/GCDMMIOBlackBox.v
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?