-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install CIRCT out of Conda #1675
Conversation
I'm glad to see these GitHub actions getting some use. I'm also glad that the factoring of These things should be usable by flows which aren't GitHub Actions, i.e. |
@@ -14,12 +14,25 @@ runs: | |||
conda-lock install --conda $(which conda) -n ${{ env.conda-env-name-no-time }}-$(date --date "${{ env.workflow-timestamp }}" +%Y%m%d)-esp-tools ./conda-reqs/conda-lock-reqs/conda-requirements-esp-tools-linux-64.conda-lock.yml | |||
conda deactivate | |||
|
|||
echo "Add extra toolchain collateral to RISC-V install area" | |||
echo "Add extra toolchain collateral + CIRCT to RISC-V install area" | |||
git submodule update --init ./conda-reqs/install-circt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this submodule to tools
? Since the install-circt stuff can be run in a non-conda environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the CIRCT stuff is not conda-specific, I think it can be outside of the conda directory.
The CIRCT community has some scripts to help install updated versions / update versions of CIRCT in repos. This PR is to see how well this works in Chipyard. There are two potential implementations of using these scripts:
EDIT: We decided on #1 since it's shifts the burden of us having to maintain a feedstock to the CIRCT devs who already publish a working version of CIRCT.
Any thoughts?
Side Update: Moves the
env.sh
generation into the conda setup part ofbuild-setup.sh
. Thus if a later part of the flow fails you still have aenv.sh
to diagnose and manually do other parts of the setup.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?