Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testchipip imports with new testchipip organization #1710

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Update testchipip imports with new testchipip organization #1710

merged 4 commits into from
Dec 21, 2023

Conversation

jerryz123
Copy link
Contributor

TestchipIP will be organized into sub-packages: ucb-bar/testchipip#210

This PR updates all the imports in chipyard to match the new sub-packaging.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

T-K-233
T-K-233 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@T-K-233 T-K-233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@jerryz123 jerryz123 merged commit 6730f55 into main Dec 21, 2023
52 checks passed
@T-K-233 T-K-233 deleted the organize_tcip branch December 22, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-K-233 T-K-233 T-K-233 approved these changes

@abejgonzalez abejgonzalez abejgonzalez approved these changes

@kevindna kevindna Awaiting requested review from kevindna

Assignees
No one assigned
Labels
changelog:changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryz123 @abejgonzalez @T-K-233