Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fix conda-lock version, >1.4.0 does not work! #1714

Merged
merged 2 commits into from
Jan 2, 2024
Merged

FIX: fix conda-lock version, >1.4.0 does not work! #1714

merged 2 commits into from
Jan 2, 2024

Conversation

T-K-233
Copy link
Member

@T-K-233 T-K-233 commented Dec 22, 2023

Related PRs / Issues:

When using conda-lock=1.4 constraint, it will install version greater than v1.4.0. With that version, build-setup.sh will halt with the following error:

image

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Documentation
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, but @abejgonzalez should confirm

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That failure isn't because of conda-lock not having the right version IIRC. From what I've noticed in the past this is a transient issue (re-running the setup script seems to work). In any case, this is strictly better than before (since we want people to be on a specific version).

@T-K-233 T-K-233 merged commit 5e0d9c5 into main Jan 2, 2024
52 checks passed
@T-K-233 T-K-233 deleted the fix-docs branch January 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants