Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed a performance degradation when emitting FIRRTL for a private SoC project, and tracked the issue down to this bit of IOBinders code. If you add a
println
statement to theIOBinder
class, like this:... and then build
RocketConfig
with:Then you will see 524287 instances of that
println
message, with many duplicate checks of the sameIOBinder
classes. Seems that the extra CDE lookup call toup
is causing a lot of issues. If you just make a single call toup
, as in this PR, you'll only see 19 instances of thatprintln
message.This performance hiccup isn't that noticeable for Rocket, but for my project, it's the difference between the
make firrtl
step taking 1 minute vs 8 minutes. I'm not adding that many extra IOBinders (maybe about 10), but there seems to be some greater-than-linear blowup in the CDE lookups with the two calls toup
.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?