-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all GPIO signals are tied off #1732
Conversation
d3fe97e
to
777c76a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, but before we do, the PR to rocket-chip-blocks must be merged.
777c76a
to
392ab4f
Compare
Okay, finally got that rocket-chip-blocks PR merged, thanks @jerryz123. Not sure if the rocket-chip-blocks bump is pulling in more changes than desired now, or if this is okay. |
This is good, thanks! |
Ok odd... this broke SPI flash.. I don't think this is related to your changes... but warrants some investigation |
I guess this is the first time that this PR is getting pulled into Chipyard, which does touch the SPI controller: chipsalliance/rocket-chip-blocks#25 |
Thanks for chasing down the commit. I've reverted it on rocket-chip-blocks |
392ab4f
to
0a922a0
Compare
0a922a0
to
262469e
Compare
np! I've merged that change into here, hopefully CI is all fixed now. |
Related PRs / Issues:
Resolves #1731.
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?