-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix submodule recusive cloning #1765
Conversation
be9197d
to
4800589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to save setup time?
Yes, its marginal, but cva6 has an insane number of submoules |
Yeah that is very true |
4800589
to
b3c50f4
Compare
b3c50f4
to
89914e4
Compare
If they aren't inited by default we should update the submodule README or add a script to clone submodules. |
Enough submods are init'd to build cva6, which is all we should support IMO. No one is using the other features. Initing the rest of cva6 can be done with the standard |
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?