Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submodule recusive cloning #1765

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix submodule recusive cloning #1765

merged 3 commits into from
Jan 26, 2024

Conversation

jerryz123
Copy link
Contributor

  • Prevents recursive clones of nvdla/cva6
  • Fixes recusive clones of rocket-chip not respecting submodule.update=none

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to save setup time?

@jerryz123
Copy link
Contributor Author

Is this to save setup time?

Yes, its marginal, but cva6 has an insane number of submoules

@joonho3020
Copy link
Contributor

Is this to save setup time?

Yes, its marginal, but cva6 has an insane number of submoules

Yeah that is very true

@joonho3020 joonho3020 self-requested a review January 26, 2024 18:16
@abejgonzalez
Copy link
Contributor

If they aren't inited by default we should update the submodule README or add a script to clone submodules.

@jerryz123
Copy link
Contributor Author

Enough submods are init'd to build cva6, which is all we should support IMO. No one is using the other features.

Initing the rest of cva6 can be done with the standard git submodule update --init --recursive generators/cva6

@jerryz123 jerryz123 merged commit b6ba10a into main Jan 26, 2024
53 checks passed
@jerryz123 jerryz123 deleted the fix-submods branch January 26, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants