Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to gcc 13 #1802

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Bump to gcc 13 #1802

merged 4 commits into from
Mar 14, 2024

Conversation

vighneshiyer
Copy link
Contributor

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Motivation for the bump is: 1) We should try to use the latest gcc to see if there are any regressions, 2) we should take advantage of any new compiler optimizations, and 3) verilator supposedly performs much better on large designs with -Oz which only exists in modern gcc. For now, I just want to see what breaks in CI.

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending FS tests pass)

@jerryz123
Copy link
Contributor

We should bump the RISCV toolchain to 13 as well.

@vighneshiyer
Copy link
Contributor Author

@abejgonzalez The Firesim tests will pass once Firesim is bumped. Could you do that bump first, then I can rebase this branch on top of that bump?

@jerryz123
Copy link
Contributor

Can you just do the bump in this PR? Just use the latest main of firesim

@jerryz123 jerryz123 merged commit 9a7e5f3 into main Mar 14, 2024
57 checks passed
@jerryz123 jerryz123 deleted the gcc_13_bump branch March 14, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants