-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy SFC flags #1859
Remove legacy SFC flags #1859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just fork the flow into 2:
- Normal - Chisel Generator -> MFC -> Verilog
- Experimental - Chisel Generator -> SFC -> MFC (or potentially skip this) -> Verilog
The "experimental" side of it would be untested and up to power users to bugfix (IMO this pushes users to write MFC passes which can now be out-of-tree injected)
Do we have any evidence anyone wants 2? This will fundamentally not work with chisel6, as the chisel6 emitted CHIRRTL is not compatible with SFC. Assuming this gets in, my initial chisel6 PRs will allow the users to choose whether to compile with chisel6 or chisel3. |
Also, see in #1860 that this enables removing all of GenerateModelStageMain, which I see as a huge benefit, and after that is done, the makefile flow is drastically simplified. |
I think some people wanted an SFC option (instead of having to write MFC passes) but I don't think anyone was using the SFC passes currently (only people who've used them in the past). I'm personally pro-removing-SFC (but I haven't used the pass injection in years) but I remember having a conversation w/ folks on keeping/removing it hence the recommendation. |
A clean transition to chisel6 is not possible without removing this seldom-used feature. Once the RTL-sim flow is in Chisel6, I'll submit another PR allowing a chisel6 frontend to use SFC firrtl passes, for firesim. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixed types are never generated now. Custom SFC passes/flags are not known to be used. Preps the way for chisel6
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?