fix README section on adding new submodules #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonamid
approved these changes
Jan 29, 2019
abejgonzalez
reviewed
Feb 1, 2019
| @@ -396,7 +396,16 @@ to the project template. | |||
|
|
|||
| git submodule add https://git-repository.com/yourproject.git | |||
|
|
|||
| Then add `yourproject` to the `EXTRA_PACKAGES` variable in the Makefrag. | |||
There was a problem hiding this comment.
It is still important to keep this right just so that make still tracks the dependencies. I know that SBT handles the build once it is called but I think this is good to keep right?
There was a problem hiding this comment.
For example, the case that I am trying to avoid is this... you make a change in your new submodule "yourproject" and try to compile without added to the MakeFrag, then make will see that there is no changed sources and the build will continue without taking into account the updated changes. This is if the firrtl file is already generated.
|
Other than my comment, I can also confirm that this works! LGTM |
albert-magyar
pushed a commit
that referenced
this pull request
Jul 18, 2019
* stop exceptions on empty conf files * emit empty verilog file | warn users * put else's on same line as closing bracket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.