-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rebar] add sifive blocks | add rebar configs for boom #69
Conversation
Why does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add an example that has some sifive-block peripheral maybe GPIOs?
I'm ok with that being a separate PR if you think it would be cleaner.
I also agree with Alon about creating extra packages. |
|
Actually, are you all in favor of getting rid of the |
… naming | split generator file
Can you make sure you can run an assembly test on both boom and rocket before merging this? |
Okay, I think this PR is ready to be merged in. I addressed @colinschmidt concerns about building rocket. See the Additionally, made sure that asm tests ran correctly on rebar boom, rebar rocket, rocketchip, and boom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Spitballing here, but I'm wondering if we can just mandate that all designs extend a trait "tieOffIOInTestHarness", that has a method (implicit p) => Unit that just barfs out all of the requisite hardware for RTL simulation, BuildTop can just return a Module that extends that trait and this can be invoked in the testHarness.
* * Separate connect methods of BlockDevice, SerialAdapter, and UARTAdapter into objects for modularity * Fix deprecation warnings * SerialIO should not be an Option * Add suggestName for uart_sim * CR feedback; Move the option logic into SerialAdapter methods
Fix macrocompiler for RW mask port
Added
sifive-blocks
without actually using it. Added BOOM rebar configurations.Question to the pro Chisel devs in the group. Is there any way for the
BuildTop
parameter to be general so that bothBoomTop
andRocketTop
work? Similar to a upper bound type for a class parameter? I was unable to figure this out, but I figured this was sufficient for now since it matchesfirechip