This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chick
commented
Mar 24, 2020
- Create new VcsBackendAnnotation
- Create support utilities for Vcs building tools
- CopyVpiFiles move vpi and header files into place
- GenVcsVerilogHarness Compile stuff
- VcsAnnotations control behavior of the Vcs backend
- Create VcsBackend, a trivial sub-classing of VerilatorBackend
- Create VcsExecutive
- constructs VcsBackEnd requirements calls the constructor
- Create SimpleVcsTests
- Added String to Uniquify Verilator and Vcs Tests
- Suppress VCS tests if VCS not present in path
- Updates to PR Add vcs backend support #58
- Fixed CopyVpiFiles
- looks like this might fail if early file was there but a late one wasn't
- this code came from chisel-testers
- Fix top level test names
- behavior of "Testers2 with Vcs"
- behavior of "Testers2 with Verilator"
- Shortened VCS to just see if a simple circuit will build and simulate.
- in long run we still need mechanism to run an arbitrary test with arbitrary backend
- Create new VcsBackendAnnotation
- Create support utilities for Vcs building tools
- CopyVpiFiles move vpi and header files into place
- GenVcsVerilogHarness Compile stuff
- VcsAnnotations control behavior of the Vcs backend
- Create VcsBackend, a trivial sub-classing of VerilatorBackend
- Create VcsExecutive
- constructs VcsBackEnd requirements calls the constructor
- Create SimpleVcsTests
- Added String to Uniquify Verilator and Vcs Tests
- Fixed CopyVpiFiles
- looks like this might fail if early file was there but a late one wasn't
- this code came from chisel-testers
- Fix top level test names
- behavior of "Testers2 with Vcs"
- behavior of "Testers2 with Verilator"
- Shortened VCS to just see if a simple circuit will build and simulate.
- in long run we still need mechanism to run an arbitrary test with arbitrary backend
- Create new VcsBackendAnnotation - Create support utilities for Vcs building tools - CopyVpiFiles move vpi and header files into place - GenVcsVerilogHarness Compile stuff - VcsAnnotations control behavior of the Vcs backend - Create VcsBackend, a trivial sub-classing of VerilatorBackend - Create VcsExecutive - constructs VcsBackEnd requirements calls the constructor - Create SimpleVcsTests - Added String to Uniquify Verilator and Vcs Tests - Suppress VCS tests if VCS not present in path - Updates to PR #58 - Fixed CopyVpiFiles - looks like this might fail if early file was there but a late one wasn't - this code came from chisel-testers - Fix top level test names - behavior of "Testers2 with Vcs" - behavior of "Testers2 with Verilator" - Shortened VCS to just see if a simple circuit will build and simulate. - in long run we still need mechanism to run an arbitrary test with arbitrary backend - Create new VcsBackendAnnotation - Create support utilities for Vcs building tools - CopyVpiFiles move vpi and header files into place - GenVcsVerilogHarness Compile stuff - VcsAnnotations control behavior of the Vcs backend - Create VcsBackend, a trivial sub-classing of VerilatorBackend - Create VcsExecutive - constructs VcsBackEnd requirements calls the constructor - Create SimpleVcsTests - Added String to Uniquify Verilator and Vcs Tests - Fixed CopyVpiFiles - looks like this might fail if early file was there but a late one wasn't - this code came from chisel-testers - Fix top level test names - behavior of "Testers2 with Vcs" - behavior of "Testers2 with Verilator" - Shortened VCS to just see if a simple circuit will build and simulate. - in long run we still need mechanism to run an arbitrary test with arbitrary backend merged latest version of master then did lots and lots of cleanup
Replacement for PR #58 |
Closed
ducky64
approved these changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine at a glance, probably doesn't need a super in-depth review for stuff going into legacy. I assume it's been tested somewhere?
Also, what happens if this is run on a platform without VCS (probably would be the case for many people)? Ideally it would give a skipped test warning, or just pass?
The test of VCS gives a "Test Canceled: firrtl.FileUtils.isVCSAvailable was false" message |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.