Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

changed RawTester.test to accept a testname #533

Merged
merged 4 commits into from
Jul 11, 2022

Conversation

lsteveol
Copy link
Contributor

RawTester.test can now accept a testName instead of defaulting to one based on the millisecond time stamp. This is similar to how RawTester.verify works.

Copy link
Collaborator

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but is missing a unittest which checks that the correct directory is created. Happy to merge, once you add that test. Thanks!

@lsteveol
Copy link
Contributor Author

lsteveol commented Jul 6, 2022

Thanks for pointing that out, my apologies. I've added one that will utilize Icarus to check the RawTester.test(testName) option

@ekiwi ekiwi force-pushed the rawtester-testname-update branch from 1c2da58 to 100688c Compare July 11, 2022 14:07
Copy link
Collaborator

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test! I made it work with treadle which is the easiest default. Icarus does not seem to be required for us to test this functionality.

@ekiwi ekiwi added this to the 0.6.0 milestone Jul 11, 2022
@ekiwi ekiwi added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jul 11, 2022
@mergify mergify bot merged commit 57e0cb9 into ucb-bar:main Jul 11, 2022
@lsteveol lsteveol deleted the rawtester-testname-update branch July 11, 2022 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants