This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Allow patched versions of Verilator #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekiwi
added
the
Please Merge
ekiwi
force-pushed
the
fix/allow_patched_verilator_versions
branch
from
714b61e
to
3a0d271
Compare
ekiwi
force-pushed
the
fix/allow_patched_verilator_versions
branch
from
3a0d271
to
65bbf11
Compare
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2022
(cherry picked from commit 9a9d347)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Dec 7, 2022
(cherry picked from commit 9a9d347) Co-authored-by: Steve Burns <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to use the same version of Verilator for chiseltest that we use for cocotb testing. Currently we need to use a patched version of verilator for cocotb and this breaks the version parsing mechanism in chiseltest. This PR just allows more version names, specifically it allows the name
5.002.p(actually anything with the format D.DDD or D.DDD.anystring).