This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
partialPoke/Expect: add more tests, improve implementation #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekiwi
force-pushed
the
fix-partial-poke
branch
from
2da350f
to
e0c225d
Compare
ekiwi
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
* partialPoke/Expect: add more tests, improve implementation * fix error reporting for partialExpect (cherry picked from commit 8f692f2)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Dec 20, 2022
* partialPoke/Expect: add more tests, improve implementation * fix error reporting for partialExpect (cherry picked from commit 8f692f2) Co-authored-by: Kevin Laeufer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes partial pokes / expects slightly less broken by implementing them in terms of the normal poke / expect function. One use case that has new tests added and that was definitely somewhat broken is bundles inside of vecs.
This also removes four warnings, which - in this case and afaik - were indicative of a real bug.