Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Replace getDataNames with DataMirror.fullModulePorts in PeekPokeTester #667

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

konda-x1
Copy link
Contributor

Addresses #661.

Turns out PeekPokeTester had the same issue.

@ekiwi
Copy link
Collaborator

ekiwi commented Aug 21, 2023

oh no, good find!

Copy link
Collaborator

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@ekiwi ekiwi merged commit 94f5273 into ucb-bar:main Aug 21, 2023
24 checks passed
@konda-x1 konda-x1 deleted the opaquetype-peekpoke branch August 21, 2023 20:09
@konda-x1
Copy link
Contributor Author

Can we get this backported to 0.6?

@ekiwi
Copy link
Collaborator

ekiwi commented Aug 22, 2023

Can we get this backported to 0.6?

Would you mind doing a manual backport with a PR? I will then do the work to publish a 0.6.2 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants