This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Bugfix: loadMemoryFromFile support absolute paths #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, specifying an absolute path in loadMemoryFromFileInline would cause an error when running with treadle, because the path was absolutized using os.path.RelPath. The latter function throws an exception for absolute paths. Now both absolute and relative paths work (matching the behaviour of Verilator). Note that this has no security implications, since the previous "relative-path" based implementation also allowed "../../" paths; existing relative paths should not be affected.
|
|
ekiwi
approved these changes
Nov 16, 2023
src/test/scala/chiseltest/iotesters/examples/LoadMemoryFromFileSpec.scala
Outdated
Show resolved
Hide resolved
|
Please run |
|
Thank you! Your bug-fix will soon be available as part of the |
|
Perfect, thank you! It's fine as is, I use the latest version of Chisel (6.0.0-M3 master) with locally built chiseltest/firrtl2, so a "regular release schedule" works for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, specifying an absolute path in loadMemoryFromFileInline would cause an error when running with treadle, because the path was absolutized using os.path.RelPath. The latter function throws an exception for absolute paths.
Now both absolute and relative paths work (matching the behaviour of Verilator).
Note that this has no security implications, since the previous "relative-path" based implementation also allowed "../../" paths; existing relative paths should not be affected.