Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile warning: catch all Throwables #7

Merged
merged 1 commit into from
Dec 16, 2020
Merged

fix compile warning: catch all Throwables #7

merged 1 commit into from
Dec 16, 2020

Conversation

ingallsj
Copy link
Contributor

Type of change: paying off technical debt

Impact: no functional change

What was changed
fix compile warnings:

[warn] /barstools/mdf/scalalib/src/main/scala/SRAM.scala:55:75: This catches all Throwables. If this is really intended, use `case _ : Throwable` to clear this warning.
[warn]       case Some(x: JsString) => try { BigInt(x.as[String]) } catch { case _ => return None }
[warn]                                                                           ^

@ingallsj
Copy link
Contributor Author

Thanks for the approval, @edwardcwang! Can you, or somebody with write access, please merge this?

@edwardcwang edwardcwang merged commit e588024 into ucb-bar:master Dec 16, 2020
timsnyder-siv added a commit to sifive/barstools that referenced this pull request Dec 24, 2020
chick added a commit to ucb-bar/barstools that referenced this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants