Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Widget For libguides Author Profile #49

Open
sbagg opened this issue Jan 20, 2022 · 3 comments
Open

Component Widget For libguides Author Profile #49

sbagg opened this issue Jan 20, 2022 · 3 comments
Assignees

Comments

@sbagg
Copy link
Collaborator

sbagg commented Jan 20, 2022

Create a Person API for hydrating the author profile and create a component that uses data.

@spelkey-ucd
Copy link
Collaborator

spelkey-ucd added a commit that referenced this issue Jul 18, 2022
@spelkey-ucd
Copy link
Collaborator

spelkey-ucd commented Jul 25, 2022

@sbagg People without appointments are still showing book an appointment link: https://brand.library.ucdavis.edu/#ucdlib-author-profile

Also, put in an error state if the email is not recognized. right now it just shows:
image

@wrenaria
Copy link

wrenaria commented Sep 16, 2022

There are a couple issues with the author profiles widget that need fixed.

Links to profiles are not working on production site

The widget is not linking to the profiles on the guides-missing pages that appear for library guides that have not been migrated to the new site. Clicking on the author's name just reloads the page.

Examples:
https://library.ucdavis.edu/guide-missing/?contact_name=Megan+Van+Noord&contact_id=mgvannoord&type=libguide&guide_name=Public+Health

https://library.ucdavis.edu/guide-missing/?contact_name=Erik+Davis+Fausak&contact_id=edfausak&type=libguide&guide_name=Veterinary+Education

Styling adjustments: incorrect spacing and heading size should be adjusted

The spacing between items is showing incorrectly on both LibGuides and on the library website. Things should not be as spread out vertically as much as they are currently. It looks like there is a 1 rem margin occurring between each contact item, and that should not exist at all.

image

Also, seeing the widget in context, I think it would be better to drop the heading size to be the same font size used for h4 so it competes less with top level headings. This alteration is also reflected in the image above.

sbagg added a commit that referenced this issue Sep 17, 2022
jrmerz pushed a commit that referenced this issue Sep 19, 2022
* issue#73 changes

* issue#73 small changes

* person page change

* spacing fix

* heading and side-bar fix

* issue #49 format changes

* change version number

* delete console.log debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants