-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Widget For libguides Author Profile #49
Comments
@sbagg There is now some data in sandbox for this: https://sandbox.library.ucdavis.edu/wp-json/ucdlib-directory/person/[email protected] |
@sbagg People without appointments are still showing Also, put in an error state if the email is not recognized. right now it just shows: |
There are a couple issues with the author profiles widget that need fixed. Links to profiles are not working on production siteThe widget is not linking to the profiles on the guides-missing pages that appear for library guides that have not been migrated to the new site. Clicking on the author's name just reloads the page. Styling adjustments: incorrect spacing and heading size should be adjustedThe spacing between items is showing incorrectly on both LibGuides and on the library website. Things should not be as spread out vertically as much as they are currently. It looks like there is a 1 rem margin occurring between each contact item, and that should not exist at all. Also, seeing the widget in context, I think it would be better to drop the heading size to be the same font size used for h4 so it competes less with top level headings. This alteration is also reflected in the image above. |
* issue#73 changes * issue#73 small changes * person page change * spacing fix * heading and side-bar fix * issue #49 format changes * change version number * delete console.log debug
Create a Person API for hydrating the author profile and create a component that uses data.
The text was updated successfully, but these errors were encountered: