Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qh sils permalink #34

Merged
merged 28 commits into from
Apr 20, 2022
Merged

Qh sils permalink #34

merged 28 commits into from
Apr 20, 2022

Conversation

qjhart
Copy link
Contributor

@qjhart qjhart commented Sep 21, 2021

This is the skeleton of #30.

@qjhart qjhart requested a review from sbagg September 21, 2021 22:53
@qjhart qjhart requested review from spelkey-ucd and removed request for sbagg September 21, 2021 22:53
@qjhart qjhart marked this pull request as draft September 21, 2021 22:53
@qjhart
Copy link
Contributor Author

qjhart commented Sep 21, 2021

@sbagg, this is the skeleton of the permalink setup. I've added what I think is the best first pass at a structure, but right now it's not actaullyty getting any data.

@sbagg sbagg marked this pull request as ready for review April 19, 2022 23:42
@sbagg sbagg requested review from jrmerz and removed request for spelkey-ucd April 19, 2022 23:43
@sbagg
Copy link
Collaborator

sbagg commented Apr 19, 2022

This is the updated theme page with sils-permalink added to it.

@jrmerz
Copy link
Contributor

jrmerz commented Apr 20, 2022

@sbagg I see a two issues. first, not sure what the os package is you installed in the app, nor do I see where you use it. Additionally, you added the request package, which I don't see you use. If you need a HTTP request library that works on both client and server, use node-fetch, if you are just on the client, use the browser native fetch

@sbagg
Copy link
Collaborator

sbagg commented Apr 20, 2022

I realized neither of those libraries are used. I deleted them and pushed it back up.

@jrmerz jrmerz merged commit b3faf67 into main Apr 20, 2022
@jrmerz jrmerz deleted the qh-sils-permalink branch April 20, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants