Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/1101 - removed ability for a full access user to remove their own expiration #1263

Merged
merged 2 commits into from
Apr 8, 2020
Merged

issue/1101 - removed ability for a full access user to remove their own expiration #1263

merged 2 commits into from
Apr 8, 2020

Conversation

weining-li
Copy link
Contributor

@clpetersonucf clpetersonucf changed the base branch from master to dev/7-alexander October 23, 2019 18:17
@clpetersonucf
Copy link
Member

Works as intended. I've noticed the grayed-out expiration text is especially difficult to read in Safari:
Screen Shot 2019-11-21 at 2 34 08 PM

I'm still a little concerned about how permission collisions between two "full" access users works though. User A grants User B FULL access alongside an expiration date. User B cannot modify their own expiration date but can potentially remove User A's access. Are we okay with this scenario?

@clpetersonucf clpetersonucf merged commit 82bb578 into ucfopen:dev/7-alexander Apr 8, 2020
@clpetersonucf clpetersonucf mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weining-li @clpetersonucf