Issue/react-cay #1390
Issue/react-cay #1390
Conversation
There was a problem hiding this comment.
I've been working on actually viewing each of the new pages/components in context in the application, and am running into a few cases where values are missing or incorrect. Understandably a lot of these are edge case views to begin with. The requested changes here probably aren't comprehensive yet - I'll add more feedback as I go.
src/util/api.js
Outdated
| return fetch('/api/json/question_set_get/', fetchOptions({ body: `data=${formatFetchBody([instId, playId])}` })) | ||
| .then(qset => qset.json()) | ||
| } | ||
|
|
||
| export const apiGetQuestionSetHistory = (instId) => { | ||
| return fetch('/api/instance/history', fetchOptions({ body: `data=${formatFetchBody([instId])}` })) |
There was a problem hiding this comment.
I can understand the confusion with the API calls, but this is using the formatting required for the old (v1) API: those hitting /api/json/xxx. Newer API endpoints are added within the requisite controllers, in this case controllers/api/instance.php. This particular request is formatted for v1, which requires everything to be POST - but the instance API controller is expecting this particular call to be a GET request. It currently 405s.
…story, creator, and summary components
There was a problem hiding this comment.
There are additional changes to be made to some of these files but for the most part, aside from a few edge cases that are outside the scope of this PR, it's functional. I'm going to approve and merge into the main react branch prior to making additional tweaks.
No description provided.