Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React fixes and polish, part four #1468

Conversation

clpetersonucf
Copy link
Member

@clpetersonucf clpetersonucf commented Apr 5, 2023

  • Resolves bug with collaborator count in My Widgets
  • Styling improvements and fixes
  • Adds a contextual footer to the widget player, with a link to the Player Guide (if available) and Materia
  • Fixes contextual return URL in widget creator
  • Fixes inoperable cancel dialog in save history importer
  • Fixes styling errrors in collaborator dialog with long names
  • Rewords widget sharing text for additional clarity
  • Fixes attempt slider in the selected widget settings dialog, as mentioned in [React Branch] Settings dialog improvements #1465
  • Fixes error related to deleting a widget instance
  • Significant changes to my-widgets-page component and how it handles loading of instances. The selected widget instance should load as soon as it's presented in the paginated instance list. The throbber has moved to the top of the instance list to accommodate the change. Includes tweaks to other elements of loading behavior and adds a listener to the widget hash in the URL.
  • Updated the useUpdateWidget mutation that handles widget settings updates to no longer invalidate the widget instance list. This prevents the list from manually refreshing any time a widget setting is changed.
  • Adjustments to collaboration dialog to try and resolve type mismatch of user ID values in perms (thanks PHP 8.1!) and made sure the my-widgets page state correctly updated if you restrict your own access, as referenced in [React Branch] Deleting current user in Collaboration Dialog #1470
  • The Cancel button in the save history dialog had a tendency of wandering off when the dialog had y-overflow, it should now correctly remain where it should be

@clpetersonucf clpetersonucf added the React Branch Related to the React rewrite for Materia label Apr 5, 2023
@clpetersonucf clpetersonucf marked this pull request as ready for review April 12, 2023 20:37
Copy link
Contributor

@cayb0rg cayb0rg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything wrong with it 👍 . Really like the loading icon in My Widgets and new footer in player!

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The few remaining instances of inline styles could maybe be replaced with classes, but otherwise it looks like this is all working well.


// now that the slider value isn't actively changing, round the raw value to the nearest stop
// pass that rounded value up to the parent component
useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well enough but it's kind of finnicky. For example after setting the value to 15 and then moving the slider, it's possible to leave the slider at a spot between 10 and 15 that's close enough to 15 that it doesn't automatically round to 10, but the slider won't jump back to 15. Not really worth holding up the PR, maybe worth noting for later.

@clpetersonucf clpetersonucf merged commit 914c771 into ucfopen:issue/support-dashboard-in-react Apr 19, 2023
@clpetersonucf clpetersonucf deleted the react/fixes-and-polish-part-four branch April 19, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
React Branch Related to the React rewrite for Materia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants