Add expected img property to widget instance objects used by the LTI widget picker.
#1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eInstanceList hook to add 'img' property to all widget instance objects for backwards compatibility with any LTIs i.e. Obojobo.
… of the 'outcome_ext' key to null instead of an empty string in the case of the associated LTI parameter not being provided.
…hub.com:FrenjaminBanklin/Materia into issue/widget-picker-img-backwards-compatibility
clpetersonucf
requested changes
Sep 26, 2023
…er than the 60. Removed unnecessary iconUurl utility usage in My Widgets instance component. Added CSS style to improve the look of the widget icon in the LTI widget picker.
clpetersonucf
merged commit 90d1ce9
into
ucfopen:issue/support-dashboard-in-react
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
iconUrluse from widget picker, using it instead in theuseInstanceListhook to add theimgproperty to all widget instance objects for continued compatibility with any LTIs expecting that property such as Obojobo.Fixes the assignment of the
outcome_extkey in the LTI launch variable parsing code where it was erroneously defaulting tonullinstead of an empty string in the event thatext_outcome_data_values_acceptedis not provided by incoming LTI params.