Save History fix for new instances #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ef updates after save to fix history issue
cayb0rg
approved these changes
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple spots in the creator component were using references to the
instIdprop, which isundefinedornullwhen a new instance is initialized. The value is never updated retroactively, so hooks that prompt the creator to reload via Save History would initialize another new instance instead of using theinitExistingWidgetpath.Updated a couple references to the
instIdprop to referenceinstIdRef'scurrentvalue instead, and ensured that ref value is updated after the instance is saved (and a fresh instance ID is provided).