Add youtube-nocookie to video detection. Fixes #561

ucfopen · Apr 23, 2021 · f5213be · f5213be
1 parent c47bb78
commit f5213be
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/quail/quail/common/accessibility_tests.php b/lib/quail/quail/common/accessibility_tests.php
@@ -6450,7 +6450,7 @@ class videosEmbeddedOrLinkedNeedCaptions extends quailTest
 	*/
 	function check()
 	{
-		$search_youtube = '/(youtube|youtu\.be)/';
+		$search_youtube = '/(youtube|youtu\.be|youtube-nocookie)/';
 		$search_vimeo = '/(vimeo)/';
 
 		foreach ($this->getAllElements(array('a', 'embed', 'iframe')) as $video) {
@@ -6501,7 +6501,7 @@ class videoCaptionsAreCorrectLanguage extends quailTest
 	*/
 	function check()
 	{
-		$search_youtube = '/(youtube|youtu\.be)/';
+		$search_youtube = '/(youtube|youtu\.be|youtube-nocookie)/';
 		$search_vimeo = '/(vimeo)/';
 
 		foreach ($this->getAllElements(array('a', 'embed', 'iframe')) as $video) {
@@ -6554,7 +6554,7 @@ class videoUnlistedOrNotFound extends quailTest
 	*/
 	function check()
 	{
-		$search_youtube = '/(youtube|youtu\.be)/';
+		$search_youtube = '/(youtube|youtu\.be|youtube-nocookie)/';
 		$search_vimeo = '/(vimeo)/';
 
 		foreach ($this->getAllElements(array('a', 'embed', 'iframe')) as $video) {

diff --git a/lib/quail/quail/common/services/media/vimeo.php b/lib/quail/quail/common/services/media/vimeo.php
@@ -54,7 +54,7 @@ function captionsMissing($link_url)
 	}
 
 	/**
-	*	Checks to see if a video is missing caption information in YouTube
+	*	Checks to see if a video is missing caption information in Vimeo
 	*	@param string $link_url The URL to the video or video resource
 	*	@param string $course_locale The locale/language of the Canvas course
 	*	@return int 0 if captions are manual and wrong language, 1 if video is private, 2 if there are no captions or if manually generated and correct language

diff --git a/lib/quail/quail/common/services/media/youtube.php b/lib/quail/quail/common/services/media/youtube.php
@@ -23,6 +23,7 @@ class youtubeService extends mediaService
 	    '@youtu\.be/v/([0-9a-zA-Z_-]+)@i',
 	    '@youtu\.be/watch\?v=([0-9a-zA-Z_-]+)@i',
 	    '@youtu\.be/\?v=([0-9a-zA-Z_-]+)@i',
+		'@youtube-nocookie\.com/embed/([0-9a-zA-Z_-]+)@i',
 		);
 
 	/**