Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YouTube and Vimeo links in "View source of this issue" open in the same window #377

Closed
bagofarms opened this issue Jul 26, 2018 · 1 comment
Closed

YouTube and Vimeo links in "View source of this issue" open in the same window #377

bagofarms opened this issue Jul 26, 2018 · 1 comment
Assignees
@atarisafari
Labels
easy enhancement
Milestone
v2.6.0

Comments

@bagofarms
Copy link
Member

They should open in a new window automatically to reduce the risk of navigating the user away from UDOIT, which can cause a lot of frustration.
@bagofarms bagofarms added this to the v2.4.0 milestone Jul 26, 2018
@bagofarms
Copy link
Member Author

bagofarms commented Jul 26, 2018 •
edited
Loading

YouTube or Vimeo videos are displayed as they are in the page. If they are just a link, they'll show up as a link. A couple options would be:

  • During scanning or rendering, detect when it's a link and add target="_blank"
  • Use JS to make all YouTube or Vimeo videos open in a new window. (Or just all links?)

@bagofarms bagofarms modified the milestones: v2.4.0, v2.5.0 Nov 14, 2018
@bagofarms bagofarms modified the milestones: v2.5.0, v2.6.0 May 1, 2019
@atarisafari atarisafari self-assigned this Jun 25, 2019
bagofarms added a commit that referenced this issue Oct 2, 2019
@bagofarms
Merge pull request #429 from atarisafari/issue/377-open-links-in-new-tab
0ac888b 
Issue/377 open links in new tab fixes #377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atarisafari atarisafari

Labels
easy enhancement
Projects
None yet
Milestone
v2.6.0
Development

No branches or pull requests
2 participants
@bagofarms @atarisafari