Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LTI 1.3 initiation from LMS can be GET or POST #727

Closed
ottenhoff opened this issue Dec 11, 2021 · 0 comments · Fixed by #729
Closed

LTI 1.3 initiation from LMS can be GET or POST #727

ottenhoff opened this issue Dec 11, 2021 · 0 comments · Fixed by #729

Comments

@ottenhoff
Copy link
Contributor

Current code in src/Controller/LtiController.php only looks for POST parameters. I believe this can be both GET and POST:

https://www.imsglobal.org/forum/learning-tools-interoperability-public-forum/196841
ottenhoff added a commit to ottenhoff/UDOIT that referenced this issue Dec 13, 2021
@ottenhoff
Fixes ucfopen#727 by looking for LTI initiation in both POST and GET …
1f33068 
…per IMS spec
@bagofarms bagofarms linked a pull request Dec 15, 2021 that will close this issue
Fixes #727 by looking for LTI initiation in both POST and GET per IMS specification #729
Merged
rob-3 pushed a commit to rob-3/UDOIT that referenced this issue Jan 7, 2022
@ottenhoff @rob-3
Fixes ucfopen#727 by looking for LTI initiation in both POST and GET …
0bee6a7 
…per IMS spec
rob-3 added a commit that referenced this issue Jan 11, 2022
@rob-3
Merge pull request #729 from ottenhoff/727-fix
978055d 
Fixes #727 by looking for LTI initiation in both POST and GET per IMS specification
SimonRothUCF pushed a commit to SimonRothUCF/UDOIT that referenced this issue Feb 24, 2022
@ottenhoff @SimonRothUCF
Fixes ucfopen#727 by looking for LTI initiation in both POST and GET …
167d1f1 
…per IMS spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #727 by looking for LTI initiation in both POST and GET per IMS specification ottenhoff/UDOIT
2 participants
@ottenhoff @bagofarms