Issue157 - YouTube Data API / Captions #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue/177 docker I've reviewed this thoroughly and UDOIT functions as expected as this issue is for the most part independent of all UDOIT current functions.
feneljoseph-zz
force-pushed
the
master
branch
2 times, most recently
from
f6ef423
to
5e3e4c1
Compare
…are functionally the same.
… the functional tests automatically, and updated the README and HEROKU to contain better installation instructions.
…ravis from running them
bagofarms
requested changes
Dec 21, 2016
There was a problem hiding this comment.
Does not properly detect videos that have zero captions at all. Example: https://www.youtube.com/watch?v=c1c0a4fo1zo
…d videos that were unlisted or deleted from caption detection.
bagofarms
approved these changes
Dec 21, 2016
This was referenced Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTube Data API implementation adjusted to detect whether caption track is indeed user provided versus an Auto-generated track.