Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip table header check when role is presentation #264

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Skip table header check when role is presentation #264

merged 2 commits into from
Jun 10, 2021

Conversation

emilysachs
Copy link

@emilysachs emilysachs commented May 2, 2017 •
edited
Loading

Fixes issue #93

@bagofarms
Copy link
Member

This one is also worth taking a look at again.

@bagofarms bagofarms added this to the v2.8.0 milestone Apr 23, 2021
@AlanFCMV AlanFCMV changed the base branch from master to dev/v2-8-0 May 18, 2021 13:50
@jasonmatos23-git jasonmatos23-git self-assigned this May 18, 2021
@jasonmatos23-git
Copy link
Contributor

Code that addresses issue #93 was brought up to date, tested, and it's working fine.

@bagofarms bagofarms requested a review from AlanFCMV June 9, 2021 15:50
AlanFCMV
AlanFCMV approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@AlanFCMV AlanFCMV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked

@AlanFCMV AlanFCMV merged commit 91ba436 into dev/v2-8-0 Jun 10, 2021
@AlanFCMV AlanFCMV deleted the issue/93-table-role branch June 28, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanFCMV AlanFCMV AlanFCMV approved these changes

Assignees

@jasonmatos23-git jasonmatos23-git

Labels
None yet
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@emilysachs @bagofarms @jasonmatos23-git @AlanFCMV