Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes Bower and NPM Requirement #285

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Removes Bower and NPM Requirement #285

merged 1 commit into from
Jun 8, 2017

Conversation

iturgeon
Copy link
Member

@iturgeon iturgeon commented Jun 7, 2017 •
edited
Loading

  • No longer requires Bower & NPM to install jscolor.
  • Adds Composer requirement of jscolor and a plugin that will move it to the correct directory post install.
  • Updates composer.json & composer.lock to lock down versions of packages more accurately.
  • Removes All bower config and references
  • Removes nodejs buildpack from Heroku config
  • Updates readme to remove Bower/Node docs

Fixes #284

@iturgeon iturgeon requested a review from bagofarms June 7, 2017 16:32
@iturgeon iturgeon force-pushed the issue/284-simplify-install-by-removing-bower branch 2 times, most recently from 60bce9f to b266f18 Compare June 7, 2017 16:55
@iturgeon
Copy link
Member Author

iturgeon commented Jun 7, 2017

This is going to be a pre-req for #279

@iturgeon
Copy link
Member Author

iturgeon commented Jun 7, 2017

Heroku installs faster now :)

Compressed before to 80.3M, now is 62.6M

@iturgeon
Copy link
Member Author

iturgeon commented Jun 7, 2017

Verified jscolor still seems to work on heroku and everything installs.

@iturgeon iturgeon mentioned this pull request Jun 7, 2017
Merged
@bagofarms bagofarms changed the base branch from master to dev/v2.2.0 June 8, 2017 19:56
@bagofarms bagofarms added this to the v2.2.0 milestone Jun 8, 2017
@iturgeon
Removes Bower and NPM Requirement
cd8d6e2 
* No longer requires Bower & NPM to install jscolor.
* Adds Composer requirement of jscolor and a plugin that will move it to the correct directory post install.
* Updates composer.json & composer.lock to lock down versions of packages more accurately.
* Removes All bower config and references
* Removes nodejs buildpack from Heroku config
* Updates readme to remove Bower/Node docs
@iturgeon iturgeon force-pushed the issue/284-simplify-install-by-removing-bower branch from b266f18 to cd8d6e2 Compare June 8, 2017 21:43
bagofarms
bagofarms approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@bagofarms bagofarms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ian says it works well on Heroku. Will test more fully during our final round before merging into master.

@bagofarms bagofarms merged commit a7dd3b4 into ucfopen:dev/v2.2.0 Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagofarms bagofarms bagofarms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@iturgeon @bagofarms