Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

497 report ui filtering #498

Merged
merged 17 commits into from
Oct 2, 2020
Merged

497 report ui filtering #498

merged 17 commits into from
Oct 2, 2020

Conversation

cidilabs
Copy link
Contributor

UI enhancements to the report. Adds tabs for content types and filters for issues. Most changes are done in a new JS and CSS file, very minimal changes to existing code.

@cidilabs
Copy link
Contributor Author

Not sure if I need to update this branch to be in line with 2.7.0, or if updating 2.7.0 to match the master branch will remove all the other commits that aren't mine.

@bagofarms
Copy link
Member

bagofarms commented Mar 18, 2020

I updated this branch with Master, so only your changes should show up in this PR now.

Some feedback: I noticed on your instance that there were two scrollbars. Make sure you're calling resizeFrame() in JavaScript whenever the user does anything that will change the vertical height of the UI.

@bagofarms bagofarms added this to the v2.7.0 milestone Apr 8, 2020
@bagofarms
Copy link
Member

Updated with the latest from 2.6.4 and 2.7.0 (also up to date with master).

During my desting, I discovered another concern. The +/- button on "What does UDOIT look for?" also shows and hides the content selection boxes, but not the scan button that's right next to the content selection boxes. I think moving the scan button below the content selection boxes would make this make more sense. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants