Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/599 missing tests #600

Merged
merged 3 commits into from
Jun 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ In late 2013, the proposal submitted by UCF's Center for Distributed Learning wo
| headersHaveText | If a header tag does not contain text. |
| videoProvidesCaptions | If a video tag does not have a caption track tag. |
| videosEmbeddedOrLinkedNeedCaptions | If a YouTube or Vimeo video does not have human-generated captions. |
| brokenLink | If a link is broken |
| headingLevelSkipped | If a heading level has been skipped |
| documentReadingDirection | If text that is in Hebrew, Arabic, or Dhivehi/Maldivian does not have the dir attribute set to rtl |

### Suggestions

Expand All @@ -52,6 +55,9 @@ In late 2013, the proposal submitted by UCF's Center for Distributed Learning wo
| cssTextStyleEmphasize | If colored text is not emphasized as bold or italicized. |
| videoEmbedChecked | If an iframe, link, or object tag linking to a Dailymotion video exists on the page. |
| videoCaptionsAreCorrectLanguage | If a YouTube or Vimeo video has human-generated captions, but they do not match the set language of the course. |
| tableHasFixedWidth | If a table or its cells have fixed width |
| videoUnlistedOrNotFound | If a video is unlisted or can not be found |
| redirectedLink | If a link is redirected |

## Awards

Expand Down
5 changes: 2 additions & 3 deletions lib/quail/quail/common/accessibility_tests.php
Original file line number Diff line number Diff line change
Expand Up @@ -1920,7 +1920,6 @@ function check()

/**
* The reading direction of all text is correctly marked.
* The reading direction of all text is correctly marked.
*/


Expand All @@ -1936,7 +1935,7 @@ class documentReadingDirection extends quailTest
/**
* @var int $default_severity The default severity code for this test.
*/
var $default_severity = QUAIL_TEST_MODERATE;
var $default_severity = QUAIL_TEST_SEVERE;

/**
* @var bool $cms This test does not apply to content management systems (is document-related)
Expand All @@ -1946,7 +1945,7 @@ class documentReadingDirection extends quailTest
/**
* @var array $right_to_left The language codes that are considered right-to-left
*/
var $right_to_left = array('he', 'ar');
var $right_to_left = array('he', 'ar', 'dv');

/**
* The main check function. This is called by the parent class to actually check content
Expand Down
2 changes: 1 addition & 1 deletion lib/quail/quail/guidelines/translations/en.txt
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@
"tabIndexFollowsLogicalOrder","The tab order of a document is logical","<p>Check that the tab-order of a page is logical.</p>","2"
"formHasGoodErrorMessage","Form error messages should assist in solving errors","<p>If the form has some required fields or other ways in which the user can commit an error, check that the reply is accessible. Use the words ""required"" or ""error"" within the <code>label</code> element of input items where the errors happened, and check that the beginning of the form highlights each form error. This is not something that can be checked through automated testing and requires manual checks.</p>","3"
"formErrorMessageHelpsUser","Forms offer the user a way to check the results of their form before performing an irrevokable action","<p>If the form allows users to perform some irrevokable action, like ordreing a product, ensure that users have the ability to review the contents of the form they submitted first. This is not something that can be checked through automated testing and requires manual confirmation.</p>","3"
"documentReadingDirection","Changes in text decoration should be marked up","<p>Changes in text direction in inline content should be indicated using any HTML element (for example, <code>span</code>) with a ""dir"" attribute indicating left-to-right or right-to-left. For example, a Hebrew phrase within an english paragraph should have it's own text direction indicated.</p>","2"
"documentReadingDirection","Changes in text direction should be marked up","<p>Changes in text direction in inline content should be indicated using any HTML element (for example, <code>span</code>) with a ""dir"" attribute indicating left-to-right or right-to-left. For example, a Hebrew phrase within an english paragraph should have it's own text direction indicated.</p>","2"
"formDeleteIsReversable","Deleting items using a form should be reversable","<p>Check that, if a form has the option to delete an item, that the user has a chance to either reverse the delete process, or is asked for confirmation before the item is deleted. This is not something that can be checked through automated testing and requires manual confirmation.</p>","3"
"svgContainsTitle", "Inline SVG should use Title elements","<p>Any inline SVG image should have an embedded <code>title</code> element","1"
"cssTextHasContrast","Insufficient text color contrast with the background","<p>Text color should be easily viewable and should not be the only indicator of meaning or function. Color balance should have at least a 4.5:1 ratio for small text and 3:1 ratio for large text. Warning: using UFIXIT to fix one section of text may invalidate the contrast in nested sections of text that are not the same color.</p>","1"
Expand Down