Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused JS imports #811

Merged
merged 5 commits into from
Aug 5, 2022
Merged

Remove unused JS imports #811

merged 5 commits into from
Aug 5, 2022

Conversation

SimonRothUCF
Copy link
Contributor

This is part of issue #788, it removes unused imports. It also removes instances of eval(), but this was already done in PR #810.

@bagofarms bagofarms self-requested a review May 5, 2022 18:08
@bagofarms bagofarms modified the milestone: 3.3.0 May 5, 2022
bagofarms
bagofarms approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@bagofarms bagofarms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to drop the changes to contrast.js because the structure of that file is totally different now, but it's no longer using evals, so we're good. Thanks!

@bagofarms bagofarms merged commit 269ce5f into ucfopen:dev/v3-3-0 Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagofarms bagofarms bagofarms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonRothUCF @bagofarms