#854 flatten items from multiple array and merge into one single array #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This problem appeared to only be an issue when terms in the LMS were over 100 total. The perPage on the apiGet in CanvasAPI is set to 100 by default, so the bug was that it would retrieve 100 and on the then when it got over 100 and retrieved the second page it wouldn't work because of how terms was nested in the json |
zqian
changed the title
bagofarms
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #854
The paged Canvas terms API call returns multiple arrays.
This fix is to flatten the arrays and merge all items from all arrays. Multiple arrays are returned because UM has 101 academic terms returns, so that becomes two arrays since the default array size is 100 in Canvas api calls.