Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx configurations and php.ini to increase maximum file size. #944

Merged
merged 6 commits into from
May 1, 2024

Conversation

taheralfayad
Copy link
Contributor

@taheralfayad taheralfayad commented Apr 24, 2024

Fixes #942. In this current iteration of UDOIT, the maximum file size that the user is allowed to upload to a course is 1MB, which renders the file replacement modal useless for most PDFs. What currently happens when you try to upload a file that is >1MB is that UDOIT returns an unhandled 413 error, which isn't really that informative to the user. To combat that, I set the acceptable upload file size to 10MB in the nginx configurations for local.conf and deploy.conf. I also set upload_max_filesize and post_max_size to be 10MB in php-custom.ini.

@taheralfayad taheralfayad requested a review from dmols April 24, 2024 15:57
@taheralfayad taheralfayad changed the title Update nginx configurations and php.ini to increase maximum file size. WIP: Update nginx configurations and php.ini to increase maximum file size. Apr 26, 2024
@taheralfayad taheralfayad changed the title WIP: Update nginx configurations and php.ini to increase maximum file size. Update nginx configurations and php.ini to increase maximum file size. Apr 26, 2024
@dmols dmols assigned dmols and taheralfayad and unassigned dmols Apr 26, 2024
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on a possible wording change, but otherwise, the changes look great! I'm able to upload files of up to <10mb and see the error modal pop up when I input a file of size >10mb. Good to push.

translations/en.json Outdated Show resolved Hide resolved
Co-authored-by: Daniel Molares <[email protected]>
@dmols
Copy link
Contributor

dmols commented May 1, 2024

Changes requested were made. Good to push!

@dmols dmols merged commit c096ab5 into dev May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants